-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install instruction for plain Vim 8 #1042
base: master
Are you sure you want to change the base?
Conversation
I would rather not have all those different ways of installing jedi-vim. I would probably just recommend https://github.com/junegunn/vim-plug and remove the other options. @blueyed can decide. |
Yeah, having all the different options of installment are a recurring issue with READMEs across (Neo)Vim plugins. Here however it is a nuisance that submodules are used, which are not handled with every package manager, or when using no package manager at all. I agree in general that the README section should be revisited probably, and that it should contain instructions for Vim and NeoVim, which both have support for packages (which this change is about apparently), and then maybe vim-plug as an example for a plugin manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for attacking this.
I think it should get revisited, and could do so myself based on the given feedback, but feel free to either do it yourself, or pick it up (@davidhalter).
The first thing you need after that is an up-to-date version of Jedi. Install | ||
``git submodule update --init --recursive`` in your jedi-vim repository. | ||
mkdir -p ~/.vim/pack/git-plugins/start | ||
git clone --recursive https://github.com/davidhalter/jedi-vim.git ~/.vim/pack/git-plugins/start/jedi-vim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw: do you know if there is a preferred/recommended way to update Vim packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abitrolly do you know? How do you keep them updated?
(as for me: I am using vim-plug basically, but given the amount of local changes I still update them manually in general, i.e. by updating/merging into the Git checkout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I update with plain git
.
git -C ~/.vim/pack/git-plugins/start/jedi-vim --rebase pull
git clone --recursive https://github.com/davidhalter/jedi-vim.git ~/.vim/pack/git-plugins/start/jedi-vim | ||
|
||
Or you might want to use `pathogen <https://github.com/tpope/vim-pathogen>`_ or | ||
`Vundle <https://github.com/gmarik/vundle>`_ to install jedi-vim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this with the rest to only include instructions for vim-plug then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abitrolly what do you think? Should I/we go ahead and do so here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a user of vim
plugin managers, so won't rely on my opinion towards them.
Co-authored-by: Daniel Hahler <[email protected]>
@blueyed Feel free to merge whatever here. |
No description provided.