Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install instruction for plain Vim 8 #1042

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abitrolly
Copy link

No description provided.

@davidhalter
Copy link
Owner

I would rather not have all those different ways of installing jedi-vim. I would probably just recommend https://github.com/junegunn/vim-plug and remove the other options. @blueyed can decide.

@blueyed
Copy link
Collaborator

blueyed commented Jun 4, 2021

Yeah, having all the different options of installment are a recurring issue with READMEs across (Neo)Vim plugins.
I think people in general should be aware how to install a plugin based on some GitHub URL/slug.

Here however it is a nuisance that submodules are used, which are not handled with every package manager, or when using no package manager at all.

I agree in general that the README section should be revisited probably, and that it should contain instructions for Vim and NeoVim, which both have support for packages (which this change is about apparently), and then maybe vim-plug as an example for a plugin manager.

Copy link
Collaborator

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attacking this.

I think it should get revisited, and could do so myself based on the given feedback, but feel free to either do it yourself, or pick it up (@davidhalter).

README.rst Outdated Show resolved Hide resolved
The first thing you need after that is an up-to-date version of Jedi. Install
``git submodule update --init --recursive`` in your jedi-vim repository.
mkdir -p ~/.vim/pack/git-plugins/start
git clone --recursive https://github.com/davidhalter/jedi-vim.git ~/.vim/pack/git-plugins/start/jedi-vim
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw: do you know if there is a preferred/recommended way to update Vim packages?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no :D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abitrolly do you know? How do you keep them updated?

(as for me: I am using vim-plug basically, but given the amount of local changes I still update them manually in general, i.e. by updating/merging into the Git checkout)

Copy link
Author

@abitrolly abitrolly Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update with plain git.

git -C ~/.vim/pack/git-plugins/start/jedi-vim --rebase pull

git clone --recursive https://github.com/davidhalter/jedi-vim.git ~/.vim/pack/git-plugins/start/jedi-vim

Or you might want to use `pathogen <https://github.com/tpope/vim-pathogen>`_ or
`Vundle <https://github.com/gmarik/vundle>`_ to install jedi-vim.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this with the rest to only include instructions for vim-plug then.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abitrolly what do you think? Should I/we go ahead and do so here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a user of vim plugin managers, so won't rely on my opinion towards them.

Co-authored-by: Daniel Hahler <[email protected]>
@davidhalter
Copy link
Owner

@blueyed Feel free to merge whatever here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants